Modifications for Classifier Pipeline #189
Conversation
Revert to no scix_id
| batch_list = [] | ||
| self.logger.info('request_classifier called with filename {}'.format(filename)) | ||
| with open(filename, 'r') as f: | ||
| reader = csv.DictReader(f) |
There was a problem hiding this comment.
It might make more sense to move this to the run.py so that way this code isn't being pulled into the celery workers.
adsmp/tasks.py
Outdated
| status = app.get_msg_status(msg) | ||
| logger.info(f'Message status: {status}') |
There was a problem hiding this comment.
These could probably become debug statements long term so we aren't flooding the logs.
There was a problem hiding this comment.
Changes made and committed.
There was a problem hiding this comment.
What is the difference between the classifications column and the collections column?
There was a problem hiding this comment.
We decided to use the name classifications so it would not be confused with the existing SOLR collections field. The later commit with classifications was ment to fix the earlier one with collections.
There was a problem hiding this comment.
Do you know why this file changed? I am just a bit concerned because this alembic upgrade not matching the one that was used to upgrade the DB previously could pose an issue.
There was a problem hiding this comment.
Yeah, I was having an issue at one point so I added the if statement to check the database. I can revert it so it matches.
There was a problem hiding this comment.
Reverted file committed.
No description provided.