Skip to content

adding notification changes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding notification changes #52

wants to merge 1 commit into from

Conversation

femalves
Copy link
Contributor

@femalves femalves commented Jun 9, 2025 •
edited
Loading

@femalves femalves requested a review from tjacovich June 9, 2025 18:51
tjacovich
tjacovich approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only suggestion I have would be for tests that confirm the URL logic works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjacovich tjacovich tjacovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@femalves @tjacovich