CDS extractor index-files.sh compile to stdout #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old dataflow API was deprecated in 2.3.0. This deprecates the older APIs but immediately makes some APIs such as BarrierGuardNode.blocks invalid as they are renamed without the `deprecated` qualifier.
This one caused a new non-monotonic recursion; it is not necessary at the moment since it is not used anywhere apart from a vacuous `import`. The AMD-style module system is already defined in UI5.qll as abstract class `UserModule`; so deleting this won't break the rest of the UI5 queries.
… the expected results `SapDefineModule` in its previous form did not extend `AmdModuleDefinition::Range` which in turn extends standard library's `Module` that enables its subclasses to be identified with MaD definitions. The reason the queries have been working was thanks to `UI5AMDModule.qll` that provided a `SapAmdModule` class extending the `Module` class directly. The problem with `SapAmdModule` copy-pasted and only slightly modified the `AMD.qll` in the standard library, so it was out of sync with the standard library couterpart when the DataFlow library behind it was overhauled to have a new API. It was causing the majority of the problems when the `qlpack.yml`s were updated with the latest DataFlow API and the `SapAmdModule` failed to play nicely with the updated library modules, emitting new non-monotonic recursion errors. Therefore, this commit makes the `SapDefineModule` in `UI5.qll` extend `AmdModuleDefinition::Range` and removes the outdated `SapAmdModule`. `SapDefineModule`s are AMD-style modules defined with `sap.ui.define` or `sap.ui.require` function calls that augments the global AMD `define` functions with the capability of extending another such module.
These expected files are prepended with a deprecation warning on the old DataFlow APIs; no changes were occured in the rest of the contents.
This is to publish these QL packs with a new version.
Attempt to resolve unit test failures for PR #170 of the `advanced-security/codeql-sap-js` repo. Updates the (soon to be replaced) shell-based version of the CDS extractor as an attempted workaround for a change in cds compiler behavior when the `-o` or `--dest` options are set for the `cds compile` CLI command. Forces the cds compmiler to output to the desired .cds.json file path via stdout.
data-douser
changed the base branch from
jeongsoolee09/bump-javascript-dataflow-lib
to
main
Attempted workaround for a knownbug in some versions of the CDS compiler (i.e. `@sap/cds-dk`). Ref -> https://github.tools.sap/cap/issues/issues/17840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to resolve unit test failures for PR #170 of this repo.
Updates the (soon to be replaced) shell-based version of the CDS extractor as an attempted workaround for a change in cds compiler behavior when the
-oor--destoptions are set for thecds compileCLI command. Forces the cds compmiler to output to the desired .cds.json file path via stdout.