Add Node Actions Dist workflow #14
Conversation
| - name: "Install and Build" | ||
| run: | | ||
| npm install | ||
| npm run bundle --if-present |
There was a problem hiding this comment.
Maybe introduce the script names of bundle and bundle-exe as inputs that are defaulted, this is not a standard naming convention
| npm run bundle-exe --if-present | ||
|
|
||
| - name: "Check for uncommitted changes" | ||
| id: diff |
There was a problem hiding this comment.
Why does this have an id, it is not being referenced anywhere
| uses: actions/checkout@v4 | ||
|
|
||
| - name: "Setup Node" | ||
| uses: actions/setup-node@v2 |
| default: "main" | ||
|
|
||
| jobs: | ||
| dist-check: |
There was a problem hiding this comment.
This job does not depend on the other, is that intentional? If so it is kind of doing what the other one is with a little more, so why the two?
|
|
||
| - name: "Install and Build" | ||
| run: | | ||
| npm install |
There was a problem hiding this comment.
npm ci is probably the one you want here unless you want to update packages, ci will strictly follow the lock file and fail if there is a dependency not in it that would be installed
| git config user.name github-actions | ||
| git config user.email [email protected] | ||
|
|
||
| git add . |
There was a problem hiding this comment.
If you know this to be the dist directory or something the user can specify, maybe lock it to that and then ensure that there are no extra changes outside of that, as that is sign something "additional" happened that was not expected?
Key changes:
.github/workflows/actions-dist-node.yml: Added a new GitHub Actions workflow named "Actions Dist - Node". This workflow is triggered on a workflow call and has two jobs:dist-check: This job checks for uncommitted changes in the dist folder for pull requests. It runs on ubuntu-latest, checks out the repository, sets up Node.js, installs and builds the project, and then checks for uncommitted changes.dist-dependabot: This job updates the dist folder for dependabot commits in the specified branch. It runs on ubuntu-latest, checks out the repository, sets up Node.js, installs and builds the project, checks that the build is clean, and if not, updates the release files.