-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PNG compression #2098
PNG compression #2098
Conversation
I'm sorry, but this PR is not good at all. There are multiple major issues with this. Compilation issues:
You could start with making this work on Windows at minimum, for example. Code issues:
Overall, the rule of thumb is to start with adding only minimal code necessary for a purpose of a feature. Logical issues:
After this is done, then will then be possible to actually test it on real game projects, see if it adds benefit for compression sizes, and so on. |
Thank you. I'll follow the guidelines |
Okay, I was not clear about the zlib library. We do not push whole library sources into the repository, unless there's no other choice. This is redundant, and also this prevents platforms like Linux use the libs installed on their systems. Instead we add corresponding library to the list of linked libs. I will probably have to explain how. |
I tried to explain how to add a lib dependency in MSVS here: I think it's best to begin with Windows, since it's required to test this feature with the Editor. If you have questions, please ask! |
Hello I did some more changes following your guidelines, but not clear about the dependencies. |
I will try making a properly linked test in a separate PR, based on your code, and test if that works in principle. |
Made #2111 based on your suggestion. I will close this one. |
Hello, I tried to do the PNG compression implementation.
I was not able to test if it works, I just get there reading documentation, but not really sure if it would work.