Summary
This vulnerability affects JUnit's support for writing Open Test Reporting XML files which is an opt-in feature of junit-platform-reporting.
If a repository is cloned using a GitHub token or other credentials in its URL, for example:
git clone https://${GH_APP}:${GH_TOKEN}@github.com/example/example.gitThe credentials are captured by OpenTestReportGeneratingListener which produces (trimmed for brevity):
<infrastructure>
<git:repository originUrl="https://username:[email protected]/example/example.git" />
</infrastructure>Details
https://github.com/junit-team/junit5/blob/6b7764dac92fd35cb348152d1b37f8726875a4e0/junit-platform-reporting/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java#L183
I think this should be configurable in some way to exclude select git information or exclude it entirely.
PoC
- Clone a repo using a GitHub token as shown above.
- Enable the listener
junit.platform.reporting.open.xml.enabled=true
- Observe report captures credentials
Impact
Depending on the level of access of the token, it can be nothing, limited, or everything.
If these test reports are published or stored anywhere public, then there is the possibility that a rouge attacker can steal the token and perform elevated actions by impersonating the user or app.
Resolution
JUnit 5.13.2 and later replace credentials in the URL with ***. Moreover, including any Git metadata in the XML output is now an opt-in feature that can be enabled via the new junit.platform.reporting.open.xml.git.enabled=true configuration parameter but is not included by default.
References
ciscoo Reporter
marcphilipp Remediation developer
Summary
This vulnerability affects JUnit's support for writing Open Test Reporting XML files which is an opt-in feature of
junit-platform-reporting.If a repository is cloned using a GitHub token or other credentials in its URL, for example:
The credentials are captured by
OpenTestReportGeneratingListenerwhich produces (trimmed for brevity):Details
https://github.com/junit-team/junit5/blob/6b7764dac92fd35cb348152d1b37f8726875a4e0/junit-platform-reporting/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java#L183
I think this should be configurable in some way to exclude select git information or exclude it entirely.
PoC
junit.platform.reporting.open.xml.enabled=trueImpact
Depending on the level of access of the token, it can be nothing, limited, or everything.
If these test reports are published or stored anywhere public, then there is the possibility that a rouge attacker can steal the token and perform elevated actions by impersonating the user or app.
Resolution
JUnit 5.13.2 and later replace credentials in the URL with
***. Moreover, including any Git metadata in the XML output is now an opt-in feature that can be enabled via the newjunit.platform.reporting.open.xml.git.enabled=trueconfiguration parameter but is not included by default.References