feat: move version in gradle.properties #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to set the version from the command line when we build. Signed-off-by: Leonidas Spyropoulos <[email protected]>
|
@inglor Is this PR still relevant? |
Author
|
Yes it's still relevant for the reasons explained in the commit message. |
|
Could you resolve the conflicts? |
Author
|
Yes until next version - but maintainer needs to response otherwise the next version will also be conflicting. |
|
@pb82 сould you pay attention to this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to set the version from the command lineduring build.
What
Moving version in properties means it can be overwritten during the execution of gradle commands
Why
See motivation
How
Moving to gradle.properties are read before it reads the gradle.build file and can be overwritten from cli.
Verification Steps
Build without the
-Pversion=3.0.0and it build the one specified in the gradle.propertiesBuild with the
-Pversion=3.0.0and will build the version specified in cli.Checklist:
Progress
Additional Notes
N/A