Skip to content

Conversation

@jannickherrmann
Copy link
Contributor

@jannickherrmann jannickherrmann commented Jun 17, 2024

Motivation

To ensure platform independence for Maven builds and to align with best practices for encoding standards.

Relates to: #205

What

Added Maven wrapper and set UTF-8 as default encoding.

Why

To make the build process more consistent across different platforms and to avoid encoding-related issues.

How

  • Added Maven wrapper files (mvnw, mvnw.cmd, .mvn/wrapper/)
  • Configured Maven to use UTF-8 encoding by default (<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> in pom.xml)

Verification Steps

  1. Clone the repository.
  2. Navigate to the project directory.
  3. Verify that the Maven wrapper files (mvnw, mvnw.cmd) are present.
  4. Open pom.xml and confirm <project.build.sourceEncoding> is set to UTF-8.
  5. Run a build using the Maven wrapper (./mvnw clean install) and ensure the build completes successfully on different platforms (Windows, macOS, Linux) and no warning appeared for source encodig.

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task

Additional Notes

No additional notes.

@jannickherrmann jannickherrmann changed the title Feature/maven wrapper Add maven wrapper and utf-8 standard encoding Jun 18, 2024
@pb82
Copy link
Contributor

pb82 commented Jul 8, 2024

@jannickherrmann thanks, I can confirm that the wrapper works (after marking the script as executable)

@jannickherrmann
Copy link
Contributor Author

@pb82 thanks for the comment, i made the wrapper for unix/mac systems executable by default and pushed it. works on windows maschines

@alexted
Copy link

alexted commented Apr 12, 2025

@jannickherrmann could you update the PR and resolve merge conflicts?

- set utf-8 to default encoding
@jannickherrmann
Copy link
Contributor Author

@alexted Thanks for the feedback! I've updated the PR and resolved the merge conflicts. Let me know if there's anything else you'd like me to adjust.

@alexted
Copy link

alexted commented May 4, 2025

@pb82 сould you pay attention to this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants