SERVER-216

[cinterloper]

Built packages with links to JFrog are available in the Actions tab above

Integration tests are here.

Test cases download the current build from JFrog and install it in a fresh container, then execute it with the --help argument

You need a JFrog username and token to execute the test cases, an example is in the README.sh

[dwelch-spike]

Why is there no gha-test-main.sh script in this PR?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.09%. Comparing base (a09177e) to head (18ceaf2).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   69.01%   69.09%   +0.08%     
==========================================
  Files          92       92              
  Lines       21549    21673     +124     
==========================================
+ Hits        14871    14975     +104     
- Misses       6678     6698      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pvinh-spike]

I've committed needed changes for makefiles and with that this file should be changed to:

function build_packages(){
if [ "$ENV_DISTRO" = "" ]; then
echo "ENV_DISTRO is not set"
return
fi
chown -R root:root .
GIT_DIR=$(git rev-parse --show-toplevel)
cd "$GIT_DIR"

echo "building package for $BUILD_DISTRO"

if [[ $ENV_DISTRO == "ubuntu" ]]; then
make deb
elif [[ $ENV_DISTRO == "debian" ]]; then
make deb
elif [[ $ENV_DISTRO == "el" ]]; then
make rpm
elif [[ $ENV_DISTRO == "amzn" ]]; then
make rpm
else
make tar
fi

mkdir -p /tmp/output/$ENV_DISTRO
cp -a $GIT_DIR/pkg/target/* /tmp/output/$ENV_DISTRO
}

[pvinh-spike]

We need to add this line in all *.yaml :
git config --global --add safe.directory "$GITHUB_WORKSPACE"

[cinterloper]

The PR have 2 set of Dockerfile, one for build and one for test. Should we combine them?

No, they take different build arguments and have different purposes.

[cinterloper]

We need to add this line in all *.yaml : git config --global --add safe.directory "$GITHUB_WORKSPACE"

What does that do?