Skip to content

Check AerospikeError receiver for nil in exported methods #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v8
Choose a base branch
from
Open

Check AerospikeError receiver for nil in exported methods #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ type AerospikeError struct {
// and changed the data. Only applies to commands that change data
InDoubt bool

// Iteration determies on which retry the error occurred
// Iteration determines on which retry the error occurred
Iteration int

// Includes stack frames for the error
Expand Down Expand Up @@ -217,7 +217,7 @@ func (ase *AerospikeError) iter(i int) Error {
// IsInDoubt signifies that the write operation may have gone through on the server
// but the client is not able to confirm that due an error.
func (ase *AerospikeError) IsInDoubt() bool {
return ase.InDoubt
return ase != nil && ase.InDoubt
}

// Matches returns true if the error or any of its wrapped errors contains
Expand Down Expand Up @@ -294,6 +294,10 @@ func (ase *AerospikeError) Is(e error) bool {

// Unwrap will return the error wrapped inside the error, or nil.
func (ase *AerospikeError) Unwrap() error {
if ase == nil {
return nil
}

return ase.wrapped
}

Expand Down