feat: Add support for vertical scaling (storage scaling) [KO-448] #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
force-pushed
the
feature/KO-448-support-vertical-scaling
branch
from
ecf6c85 to
ac551ba
Compare
abhishekdwivedi3060
changed the title
pkg/utils.go
Outdated
| aeroCluster *asdbv1.AerospikeCluster, rackID int, podName, | ||
| rackRevision string, | ||
| ) (string, error) { | ||
| const allowed = "bcedf" |
Contributor
There was a problem hiding this comment.
why const allowed = "bcedf"?
Contributor
Author
There was a problem hiding this comment.
node-id is a hexa decimal value. It cake take abcdef chars only. We are already using a char always for the existing flow without rack-revision. So with the new change, we are allowing other remaining chars for multiple rack-revisions
Contributor
There was a problem hiding this comment.
can we change it to bcdef?
Contributor
Author
There was a problem hiding this comment.
Yeah, good catch. That was a typo. Fixed it
jwalantmodi05
previously approved these changes
Nov 12, 2025
tanmayja
approved these changes
Nov 12, 2025
abhishekdwivedi3060
deleted the
feature/KO-448-support-vertical-scaling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.