feat: Add support for vertical scaling (storage scaling) [KO-448] [KO-459] #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
force-pushed
the
feature/KO-448-support-vertical-scaling
branch
from
a7d5344 to
276e920
Compare
abhishekdwivedi3060
changed the title
abhishekdwivedi3060
force-pushed
the
feature/KO-448-support-vertical-scaling
branch
from
ab1947c to
c6552d9
Compare
tanmayja
reviewed
Oct 10, 2025
| oldSts = nil | ||
| } | ||
|
|
||
| newSts, err := r.getSTS(newRack) |
Contributor
There was a problem hiding this comment.
any issue if we get new sts before old sts above 1958?
If we do so, then if oldSts == nil logic will be in continuation with oldsts code.
tanmayja
reviewed
Oct 10, 2025
api/v1/aerospikecluster_types.go
Outdated
| // Revision is a version identifier for this rack's specification, used to trigger controlled migrations | ||
| // when rack configuration changes require new StatefulSets. Change this field when making changes | ||
| // that cannot be applied in-place, such as storage updates that require pod recreation. | ||
| // The revision is appended to the rack ID for Kubernetes resource naming (e.g., <cluster>-<rackID>-<revision>). |
Contributor
There was a problem hiding this comment.
Suggested change
| // The revision is appended to the rack ID for Kubernetes resource naming (e.g., <cluster>-<rackID>-<revision>). | |
| // The revision is appended to the rack ID for Kubernetes resource naming (e.g., <cluster-name>-<rackID>-<revision>). |
|
|
||
| func (r *SingleClusterReconciler) waitForAllSTSToBeReady(ignorablePodNames sets.Set[string]) error { | ||
| r.Log.Info("Waiting for cluster to be ready") | ||
| r.Log.Info("Waiting for cluster STS to be ready") |
Contributor
There was a problem hiding this comment.
Suggested change
| r.Log.Info("Waiting for cluster STS to be ready") | |
| r.Log.Info("Waiting for all cluster STSs to be ready") |
| r.Log.Info("Waiting for cluster STS to be ready") | ||
|
|
||
| allRackIDs := sets.NewInt() | ||
| allRackIdentifier := sets.NewString() |
Contributor
There was a problem hiding this comment.
Can we call this allRackIdentifier var as allRackIdentifiers (plural form)
pkg/utils/pod.go
Outdated
| prefix := clusterName + "-" | ||
|
|
||
| rackAndPodIndexPart := strings.TrimPrefix(podName, prefix) | ||
| // parts contain only the rack-id, rack-revision (optional) pod-index. |
Contributor
There was a problem hiding this comment.
Suggested change
| // parts contain only the rack-id, rack-revision (optional) pod-index. | |
| // parts contain only the rack-id, rack-revision (optional), and pod-index. |
abhishekdwivedi3060
changed the title
jwalantmodi05
previously approved these changes
Nov 11, 2025
tanmayja
reviewed
Nov 11, 2025
test/cluster/rack_revision_test.go
Outdated
| ) | ||
|
|
||
| It( | ||
| "Should successfully migrate rack to new revision with storage update", func() { |
Contributor
There was a problem hiding this comment.
can we have a test to update the storage with no revision initially to some revision. This will test vertical scaling on existing clusters.
tanmayja
previously approved these changes
Nov 12, 2025
jwalantmodi05
approved these changes
Nov 13, 2025
abhishekdwivedi3060
deleted the
feature/KO-448-support-vertical-scaling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Rack Revision feature that enables safe, cost-effective storage updates for Aerospike clusters by implementing a gradual pod-by-pod migration strategy instead of the old add new rack approach. Old approach required rack-aware clients to change their configuration whenever there is storage update change by adding a new rack.
Before: Storage updates required bringing up an entirely new rack before deleting the old one, leading to:
🔴 Double infrastructure cost during migration
🔴 Rack-id changes
🔴 Client configuration changes for rack-aware clients
After: Gradual pod-by-pod migration with:
✅ Gradual rollout of new changes without changing the rack-id
✅ No client side changes
RackRevision Field