SERVER-216 #76

cinterloper · 2025-09-09T23:03:56Z

Built packages with links to JFrog are available in the Actions tab above

Test cases download the current build from JFrog and install it in a fresh container, then execute it with the --help argument

You need a JFrog username and token to execute the test cases, an example is in the README.sh

.github/workflows/build-artifacts.yml

codecov-commenter · 2025-09-09T23:08:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.15%. Comparing base (490f5cd) to head (0dcc615).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files          13       13           
  Lines        1086     1086           
=======================================
  Hits          827      827           
  Misses        190      190           
  Partials       69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

.github/workflows/build-artifacts.yml

.github/workflows/mac-artifact-jfrog.yml

.github/workflows/build-artifacts.yml

pvinh-spike · 2025-10-22T22:00:33Z

.github/docker/entrypoint.sh

+      install_deps_el10
+  elif [ "$ENV_DISTRO" = "amzn2023" ]; then
+      echo "installing dependencies for Amazon 2023"
+      install_deps_redhat-amzn2023


Should it be "install_deps_amzn2023"

arrowplum

In general looks good but some of these items should be addressed (some are nits). Also it could use yamlint and shellchk (plus formatting). Trunk is a good tool for this if you haven't used it. I added the baseline trunk config as a PR in case you want to take it but have commented out the commit rules until you are adopting those.

arrowplum · 2025-10-24T19:52:30Z

.github/workflows/build-artifacts.yml

+on:
+  workflow_dispatch:
+  push:
+    branches: [ main, SERVER-216,  SERVER-434 ]


Do we want to run the build only on merge to main? Wouldn't we need to do something on PR also (either just build or build and test)

in either case should remove the branches

Suggested change

branches: [ main, SERVER-216, SERVER-434 ]

branches: [ main ]

Since this is the packaging CI workflow, I imagine we want to only build and push artifacts for the builds that are ready to go to QE.
So either merge to main, or tag creation.

The projects testing workflow is separate

I changed it build on this branch, and on tag creation.

Lets talk about this with QE, anyway removing the SERVER-216 should be the last commit here before we merge

.github/workflows/build-artifacts.yml

.github/workflows/mac-artifact-jfrog.yml

arrowplum · 2025-10-24T22:36:35Z

.github/workflows/build-artifacts.yml

+      runs-on: ${{ matrix.host }}
+      project: database
+      build-id: ${{ github.run_number }}
+      build-script: |


There is no need to && these together they can just be an inline shell script.

This would not continue if one of the commands failed, but set -e would do the same thing

Set -e runs by default (it is the default when shell part of a github action so the script mimics that behaviour

.github/docker/entrypoint.sh

.github/packaging/project/build_package.sh

arrowplum · 2025-10-24T22:50:11Z

.github/docker/entrypoint.sh

+
+if [ "$INSTALL" = false ] && [ "$BUILD_INTERNAL" = false ] && [ "$BUILD_CONTAINERS" = false ] && [ "$EXECUTE_BUILD" = false ];
+then
+    echo """Error: Options:


What is the triple quote convention?

Not a real convention.

arrowplum · 2025-10-24T22:52:28Z

.github/workflows/build-artifacts.yml

+      # artifact-name: signed-artifacts  # optional, defaults to signed-artifacts
+      # retention-days: 7               # optional, defaults to 7
+      # dry-run: false                  # optional, for future compatibility


Should remove these commented out lines

arrowplum

Also I see it is not using the bundle workflow. A bundle will have to be created in order to release or promote the artifacts. https://github.com/aerospike/shared-workflows/blob/main/.github/workflows/reusable_create-release-bundle.yaml

arrowplum · 2025-10-27T16:59:05Z

.github/workflows/build-artifacts.yml

+      runs-on: ${{ matrix.host }}
+      project: database
+      build-id: ${{ github.run_number }}
+      build-script: |


Set -e runs by default (it is the default when shell part of a github action so the script mimics that behaviour

arrowplum · 2025-10-27T17:01:04Z

.github/workflows/build-artifacts.yml

  workflow_dispatch:
  push:
-    branches: [ main, SERVER-216,  SERVER-434 ]
+    branches: [ SERVER-216 ]


You can't test merges to main but shouldn't this run for PRs not just for testing but so PR commits get tested?

.github/workflows/build-artifacts.yml

arrowplum

Looks good

.github/packaging/project/build_package.sh

arrowplum

I approved but I think the trigger is still something wrong (should be able to trigger on a pull request)

arrowplum · 2025-10-27T21:16:17Z

I approved but I think the trigger is still something wrong (should be able to trigger on a pull request)

checking to see if it is the fault of the pinned commit

arrowplum · 2025-10-27T23:02:50Z

Found the culprit. A fix there would be a one liner but investigating I started with upgrading to 2.0.1 (i hadn't noticed the ref issue yet). It is fairly straightforward to upgrade so added a pr for both (into this branch) #80

arrowplum · 2025-10-27T23:45:43Z

.github/workflows/build-artifacts.yml

-    branches:
-      - main
+  schedule:
+    - cron: '0 0 * * *' # run at Midnight UTC


If nothing changes we shouldn't produce a new build every day should we? Also I think you don't want to get rid of builds on PR (even if it doesn't do the deploy or bundle step)

Please see @kportertx's comment here
https://aerospike.atlassian.net/browse/SERVER-216?focusedCommentId=169529

If we cant do this I think we will need to update to an alternate deploy target and self-hosted runners, but I dont think that is in the scope of this release

Discussed with @arrowplum, will need to write up something. @arrowplum suggested (which you'd also suggested something similar) to build and test all commits but to only upload to jfrog commits to PRs. To keep the rules simple across projects, don't worry with "PRs that target main" since different projects have various branches used for release processes. The assumption is that a very small subset of PRs don't target a release branch.

Will also update the PRD with this info.

@kportertx OK so to clarify, we would like to rpm and dev packages on:

branch prs:

dev/*

hotfix/*

tags

Delivering these builds to QE I assumed will go through the packaging system - although if we want to keep the old system as well thats a possibility.
If we need to deliver packaged builds to QE on every commit we will need another place to store them (flat file bucket comes to mind)

cinterloper · 2025-10-29T18:21:01Z

Moving common/ code to https://github.com/aerospike/server-packaging-common/

pvinh-spike · 2025-10-29T23:09:46Z

pkg/Makefile

 # Package variables
-NAME = "asconfig"
-VERSION = $(shell git describe --tags --always)
+BUILD_DISTRO ?= $(shell .github/packaging/common/os_version.sh)


Should be:
BUILD_DISTRO ?= $(shell $(PKG_DIR)/../.github/packaging/common/os_version.sh)

these should be resolved now

pvinh-spike

There is no asconfig target in top Makefile so the following need to be changed:
.PHONY: all
all: $(ACONFIG_BIN) deb rpm tar

.PHONY: deb
deb: $(ACONFIG_BIN)
$(MAKE) -C $(ROOT_DIR)/pkg/ $@

.PHONY: rpm
rpm: $(ACONFIG_BIN)
$(MAKE) -C $(ROOT_DIR)/pkg/ $@

.PHONY: tar
tar: $(ACONFIG_BIN)
$(MAKE) -C $(ROOT_DIR)/pkg/ $@

pvinh-spike

It would be helpful to have usages/descriptions in scripts. It will make maintenance them easier.

pvinh-spike

LGTM assuming warning from github-advanced-security[bot] reviewed and determined no changes needed.

dwelch-spike · 2025-11-06T23:24:21Z

.github/workflows/build-artifacts.yml

+          - el10
+          - amzn2023
+          - debian12
+          #- debian13


We talked about this in the walkthrough but noting it for later. re-enable this when possible.

dwelch-spike

LGTM left a comment as a reminder of something that came up in the walkthrough but this looks good as is to me 👍

kportertx · 2025-11-07T17:02:13Z

.github/packaging/project/gha-main.sh

+#!/usr/bin/env bash
+set -xeuo pipefail
+DISTRO="$1"
+env


Is this for debugging? Do we know it this may dump secrets to the log?

@kportertx I think the secrets are redacted by value in the logs

but it is for debugging

github-advanced-security bot found potential problems Sep 9, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 12, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 19, 2025

View reviewed changes

github-advanced-security bot found potential problems Sep 20, 2025

View reviewed changes

.github/workflows/mac-artifact-jfrog.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Oct 13, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Oct 13, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

cinterloper marked this pull request as ready for review October 15, 2025 19:46

github-advanced-security bot found potential problems Oct 20, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Oct 20, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

cinterloper requested review from arrowplum, dwelch-spike and pvinh-spike October 20, 2025 23:30

github-advanced-security bot found potential problems Oct 22, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

pvinh-spike reviewed Oct 22, 2025

View reviewed changes

cinterloper requested review from a-spiker and kportertx October 23, 2025 05:38

arrowplum requested changes Oct 24, 2025

View reviewed changes

arrowplum reviewed Oct 24, 2025

View reviewed changes

cinterloper requested review from arrowplum and pvinh-spike October 25, 2025 02:53

arrowplum reviewed Oct 27, 2025

View reviewed changes

cinterloper force-pushed the SERVER-216 branch from 48addf9 to e7faa50 Compare October 27, 2025 20:31

github-advanced-security bot found potential problems Oct 27, 2025

View reviewed changes

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

.github/workflows/build-artifacts.yml Fixed Show fixed Hide fixed

cinterloper requested a review from arrowplum October 27, 2025 20:45

arrowplum approved these changes Oct 27, 2025

View reviewed changes

.github/packaging/project/build_package.sh Show resolved Hide resolved

arrowplum requested changes Oct 27, 2025

View reviewed changes

cinterloper requested a review from arrowplum October 27, 2025 23:31

arrowplum reviewed Oct 27, 2025

View reviewed changes

cinterloper added a commit that referenced this pull request Oct 28, 2025

https://github.com/aerospike/asconfig/pull/76#discussion_r2471295982

279a1a9

cinterloper requested a review from arrowplum October 28, 2025 23:12

cinterloper marked this pull request as draft October 29, 2025 18:21

pvinh-spike reviewed Oct 29, 2025

View reviewed changes

cinterloper marked this pull request as ready for review October 31, 2025 04:20

cinterloper requested a review from pvinh-spike October 31, 2025 05:46

pvinh-spike reviewed Oct 31, 2025

View reviewed changes

pvinh-spike previously approved these changes Nov 5, 2025

View reviewed changes

cinterloper dismissed pvinh-spike’s stale review via 5066ab6 November 6, 2025 04:00

dwelch-spike reviewed Nov 6, 2025

View reviewed changes

dwelch-spike previously approved these changes Nov 6, 2025

View reviewed changes

kportertx reviewed Nov 7, 2025

View reviewed changes

cinterloper dismissed dwelch-spike’s stale review via d173e21 November 7, 2025 23:31

cinterloper added 2 commits November 14, 2025 16:49

SERVER-216

38ba5ae

remove debugging statements

211d847

cinterloper force-pushed the SERVER-216 branch from 412cf2d to 211d847 Compare November 14, 2025 22:55

cinterloper closed this Nov 14, 2025

	branches: [ main, SERVER-216, SERVER-434 ]
	branches: [ main ]

SERVER-216 #76

SERVER-216 #76

Uh oh!

Conversation

cinterloper commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arrowplum left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arrowplum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arrowplum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arrowplum left a comment

Choose a reason for hiding this comment

cinterloper commented Sep 9, 2025 •

edited

Loading

codecov-commenter commented Sep 9, 2025 •

edited

Loading

arrowplum left a comment •

edited

Loading

arrowplum commented Oct 27, 2025 •

edited

Loading