-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Numba support across the entire test suite #1289
Draft
brandonwillard
wants to merge
8
commits into
aesara-devs:main
Choose a base branch
from
brandonwillard:numba-default-test-suite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test Numba support across the entire test suite #1289
brandonwillard
wants to merge
8
commits into
aesara-devs:main
from
brandonwillard:numba-default-test-suite
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
the
backend compatibility
Issues relating to compatibility with backends called by this library
label
Nov 10, 2022
brandonwillard
force-pushed
the
numba-default-test-suite
branch
3 times, most recently
from
November 10, 2022 01:31
7f270b2
to
8b44488
Compare
1 task
brandonwillard
force-pushed
the
numba-default-test-suite
branch
2 times, most recently
from
November 11, 2022 00:17
72a268c
to
66288b6
Compare
brandonwillard
force-pushed
the
numba-default-test-suite
branch
from
November 11, 2022 16:00
66288b6
to
c0ed750
Compare
Do not merge this commit; it is intended for temporary use in a draft PR.
brandonwillard
force-pushed
the
numba-default-test-suite
branch
from
November 20, 2022 19:47
c0ed750
to
d60bd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend compatibility
Issues relating to compatibility with backends called by this library
Numba
Involves Numba transpilation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for debugging and assessing the state of Numba transpilation across the entire test suite. The underlying branch is based on #1245.
N.B. This is essentially a follow-up to #618.
Overall, we want to see the sorts of errors produced under the Numba backend and create issues for the ones that look like genuine bugs and missing features.
VM
We're looking for as much coverage as possible, so tests that unnecessarily force the use of the C backend need to be changed.
RandomState
This isn't supported by Numba.