Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Numba support across the entire test suite #1289

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Nov 10, 2022

This PR is for debugging and assessing the state of Numba transpilation across the entire test suite. The underlying branch is based on #1245.

N.B. This is essentially a follow-up to #618.

Overall, we want to see the sorts of errors produced under the Numba backend and create issues for the ones that look like genuine bugs and missing features.

  • Change explicit and unnecessary uses of the C VM
    We're looking for as much coverage as possible, so tests that unnecessarily force the use of the C backend need to be changed.
  • Change/remove uses of RandomState
    This isn't supported by Numba.

@brandonwillard brandonwillard added the Numba Involves Numba transpilation label Nov 10, 2022
@brandonwillard brandonwillard marked this pull request as draft November 10, 2022 00:28
@brandonwillard brandonwillard added the backend compatibility Issues relating to compatibility with backends called by this library label Nov 10, 2022
@brandonwillard brandonwillard force-pushed the numba-default-test-suite branch 3 times, most recently from 7f270b2 to 8b44488 Compare November 10, 2022 01:31
@brandonwillard brandonwillard force-pushed the numba-default-test-suite branch 2 times, most recently from 72a268c to 66288b6 Compare November 11, 2022 00:17
@brandonwillard brandonwillard marked this pull request as ready for review November 11, 2022 00:43
@brandonwillard brandonwillard marked this pull request as draft November 11, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend compatibility Issues relating to compatibility with backends called by this library Numba Involves Numba transpilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant