Skip to content

reload on ssl cert change #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025
Merged

reload on ssl cert change #10

merged 1 commit into from
Jun 15, 2025

Conversation

aessing
Copy link
Owner

@aessing aessing commented Jun 15, 2025

Pull Request

Description

Corrected error with reloader not automatically reloading on SSL certificate change

@aessing aessing requested a review from Copilot June 15, 2025 18:25
@aessing aessing self-assigned this Jun 15, 2025
@aessing aessing added priority - high Highest priority type - bug Something isn't working as expected status - ready for review Ready for code review labels Jun 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables the reloader by switching the annotation from "disabled" to "enabled" to address the issue where SSL certificate changes were not triggering a reload.

  • Adjusted the reloader configuration in the namespace file
Comments suppressed due to low confidence (1)

Applications/Nameserver/base/resources/namespace.yaml:7

  • The reloader annotation is now enabled; please ensure that any related documentation or tests confirm that SSL certificate changes trigger the expected reload behavior.
    reloader.stakater.com/reload: 'enabled'

@aessing aessing merged commit 72aa637 into main Jun 15, 2025
2 checks passed
@aessing aessing deleted the bug/nameserver-reload branch June 15, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority - high Highest priority status - ready for review Ready for code review type - bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant