-
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/pihole #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pihole #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds three new applications to support a comprehensive Home-Nameserver-System: Pi-hole (DNS sinkhole), Nebula-Sync (Pi-hole synchronization), and Unbound (recursive DNS resolver). The implementation creates a DNS resolution chain where users query Pi-hole, which forwards to Unbound for recursive resolution or to a local Nameserver (Bind) for local DNS entries, with Nebula-Sync providing high availability through Pi-hole instance synchronization.
- Complete Kubernetes deployment manifests for Pi-hole, Unbound, and Nebula-Sync applications
- Configuration templates and sample overlays for customization
- Integration with existing infrastructure (Traefik, cert-manager, Multus networking)
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
Applications/Pi-hole/* | StatefulSet-based Pi-hole deployment with web interface, DNS filtering, and persistent storage |
Applications/Unbound/* | Deployment-based recursive DNS resolver with comprehensive security and performance configurations |
Applications/Nebula-Sync/* | Deployment for synchronizing Pi-hole configurations between multiple instances |
Comments suppressed due to low confidence (4)
Applications/Unbound/overlay/_SAMPLE/transformers/replicas.yaml:5
- [nitpick] Inconsistent naming pattern. Should be 'unbound-replica-transformer' to match the pattern used in other transformers (e.g., 'unbound-label-transformer').
name: unbound-replicatransformer
Applications/Pi-hole/overlay/_SAMPLE/transformers/replicas.yaml:5
- [nitpick] Inconsistent naming pattern. Should be 'pihole-replica-transformer' to match the pattern used in other transformers (e.g., 'pihole-label-transformer').
name: pihole-replicatransformer
Applications/Nebula-Sync/overlay/_SAMPLE/transformers/replicas.yaml:5
- [nitpick] Inconsistent naming pattern. Should be 'nebula-sync-replica-transformer' to match the pattern used in other transformers (e.g., 'nebula-sync-label-transformer').
name: nebula-sync-replicatransformer
# At least one of a DNS Name, URI, or IP address is required. | ||
dnsNames: | ||
- CHANGE_ME | ||
- CHANGE_ME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate 'CHANGE_ME' placeholder in dnsNames array. Consider removing one or providing a more descriptive placeholder comment.
# At least one of a DNS Name, URI, or IP address is required. | |
dnsNames: | |
- CHANGE_ME | |
- CHANGE_ME | |
# At least one DNS Name is required. Add additional DNS names as needed. | |
dnsNames: | |
- CHANGE_ME # Replace with your primary DNS name | |
# - ADDITIONAL_DNS_NAME # Uncomment and replace to add more DNS names |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Andre Essing <[email protected]>
Pull Request
Description
Adding Pi-hole, Nebula-Sync and Unbound as applications and have some small changes to Nameserver (Bind).
The idea is to have a whole Home-Nameserver-System
User -> Pi-Hole -> Unbound -> Forwarder (e.g. Quad9 - for Internet DNS resolution)
|-----> Nameserver (Bind - for Local DNS entries)
|-----> Nebula-Sync (for sync to a second Pi-Hole instance for high availability)
Types of changes
What types of changes does your change introduce?
Please put an
x
in the boxes that applyBreaking changes
Does this Pull Request cause existing functionality to not work as expected or even break.
Put an
x
in the boxes that applyHow has the changes been tested?
Checklist
Thank you for your contribution. Please review the following checklist before submitting your Pull Request.
Please put an
x
in the boxes that apply