Allow to decode contract call without function name

[davidyuk]

I feel missed the ability to decode contract call without knowing the function name using ACI. The requirement to provide function name looks unnecessary since the calldata already prefixed with the hash of that name.

To avoid ambiguity I propose to limit decoding only to the main contract (the last in ACI).

At last, I don't see a way for good naming without breaking changes.

This PR is supported by the Æternity Foundation

[dincho]

I'm positive about adding a functionality to decode function id/names, but I definitely disagree with the proposed implementation, I'll comment the code for details.

[dincho]

I prefer to have a single responsibility methods, thus something like decodeFunction without returning and decoding the actual data as it already exists as functionality

[dincho]

getFunction should fit better, have a function name that includes all parameters and return structure properties makes no sense to me, see BytecodeTypeResolver for example

[dincho]

leftover ?

[davidyuk]

nope, this example is not correct. I see this format returned in tests:

aepp-calldata-js/tests/AciContractCallEncoder.js

Lines 61 to 83 in 6cb6f2b

	test('Decode calldata', t => {
	t.plan(1)
	const decoded = encoder.decodeCall(
	CONTRACT,
	'test_template_maze',
	'cb_KxGu5Sw8G6+CAAQBSzsrAgQGCK+EAAABAAIbFCg7KwIEBgj8xaf6',
	)
	t.deepEqual(
	decoded,
	{
	functionId: 'aee52c3c',
	args: [{
	Any: [
	{origin: {x: 1n, y: 2n}, a: 3n, b: 4n},
	{Yep: [10n]},
	20n,
	{origin: {x: 1n, y: 2n}, a: 3n, b: 4n},
	]
	}]
	}
	)
	})

[dincho]

leftover?

[dincho]

thanks