Initial draft of staking, rewards & penalties. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happi
changed the title
happi
changed the title
hanssv
reviewed
Nov 24, 2024
Co-authored-by: Hans Svensson <[email protected]>
Co-authored-by: Hans Svensson <[email protected]>
Co-authored-by: Hans Svensson <[email protected]>
Co-authored-by: Hans Svensson <[email protected]>
Co-authored-by: Hans Svensson <[email protected]>
thepiwo
reviewed
Nov 25, 2024
| #### **API Functions** | ||
|
|
||
| 1. **`deposit(producer:pubkey)`** (Payable Endpoint) | ||
| - **Description**: Allows a participant to deposit tokens into the staking contract, increasing their Total Balance (TB) and Available Balance (AB). |
There was a problem hiding this comment.
increasing their Total Balance (TB)
is above defined as "deposited in the staking contract via the stake() function", but should probably be explained either there or here that this also includes the automatic restaking balance for which the stake() function hasn't been called explicitly
thepiwo
reviewed
Nov 25, 2024
ThomasArts
approved these changes
Nov 25, 2024
hanssv
reviewed
Nov 25, 2024
hanssv
reviewed
Nov 25, 2024
hanssv
reviewed
Nov 25, 2024
hanssv
reviewed
Nov 25, 2024
Comment on lines
+374
to
+376
| - **Automatic Re-Staking:** | ||
| - Tokens do not automatically unlock, instead if no change in staking is registerd they remain at stake. | ||
| - Participants must call `adjustStake()` during the next Staking Epoch to free tokens during the next staking cycle. |
There was a problem hiding this comment.
This might not make it into the first version.
There was a problem hiding this comment.
No, probably lots of things not making it into the first version.
Co-authored-by: Hans Svensson <[email protected]>
|
Ill merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some details to be worked out.
Should rewards go through the staking contract or not?
We need to figure out exact details on how to spot and create evidence of misconduct.
Details about the size of the penalties.
When exactly does the tokens become locked. My current description is from the beginning of epoch N+1. That is, during the staking epoch you can increase and decrease your stake as you want it is only at the end of the epoch that amount is locked in. Of course if you have a stake from a previous cycle that stake is also locked in.
The details and the implementation of the chain economy will be done in the next iteration of Hyperchains after input from domain experts.