Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.15 #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to Bevy 0.15 #127

wants to merge 2 commits into from

Conversation

NthTensor
Copy link

Update to Bevy 0.15, see change-log for details.

@oh-wind
Copy link

oh-wind commented Dec 10, 2024

Tank you for your work.
I ran a test. but doesn't seem to work on my machine.

Environment:

SystemInfo {
    os: "Linux rolling Arch Linux",
    kernel: "6.12.1-arch1-1", 
    cpu: "AMD Ryzen 5 7500F 6-Core Processor", 
    core_count: "6", 
    memory: "31.1 GiB"
 }

ss_20241211_002348

@NthTensor
Copy link
Author

NthTensor commented Dec 10, 2024

I'll take a look when I get time. This code probably has not been as fully tested as it should.

@@ -89,9 +89,9 @@ impl<'a> Default for RaycastSettings<'a> {
}

#[cfg(feature = "2d")]
type MeshFilter = Or<(With<Handle<Mesh>>, With<bevy_sprite::Mesh2dHandle>)>;
type MeshFilter = With<Mesh2d>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be type MeshFilter = Or<(With<Mesh3d>, With<Mesh2d>)>; not type MeshFilter = With<Mesh2d>;.
This excludes 3d meshes whenever the 2d feature is enabled.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the Raycasting ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants