Some proposed changes for your consideration #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 4 unloaded pages are not displayed initially (my layout is almost full-screen), even though only (part of) a single page is displayed after loading.
… memory footprint, especially on older configurations like Nexus 5X / API 23. Also, use `value.allocationByteCount` rather than `value.byteCount`, as recommended by API documentation.
…`, as the bitmap is not actually used, except for its size, and eliminate redundant `success` parameter in the completion routine (the `bitmap` parameter null/non-null status already indicates failure/success).
…has caused build failure due to missing resources in the past.
… to save memory on older devices where memory is scarce (e.g. Nexus 5X / API 23).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing to this project. This is your first pull request and we are so glad to have you onboard. We will review the request and get back to you soon. We love your contributions! Join our Discord community here to discuss this PR or ask questions.
|
Hi @tmcintos , I appreciate your contribution. Could you please resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a mixed bag of commits that I made while trying to get PdfViewer to work as desired for my app, which supports Android versions back to API 23.
This is not intended it be mergeable as-is.
I'd just like to get your thoughts on whether any of these changes would make sense to integrate into your upstream repository.
I have struggled especially with older devices with low RAM configurations (e.g. Nexus 5X / API 23 in the emulator), where I had encountered a lot of OOM crashes when scrolling quickly through medium-to-large sized PDFs (especially ones that are scanned documents from archive.org), so several of these changes were related to attempts to minimize the memory footprint.
f1b5195 was just for my own convenience in building locally and should probably be ignored.
Thank you!