feat: support for unattended zFCP configuration #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Jul 11, 2025
| Ok(self.client.put_void("/storage/dasd/config", config).await?) | ||
| } | ||
|
|
||
| pub async fn supported(&self) -> Result<bool, DASDHTTPClientError> { | ||
| Ok(self.client.get("/storage/dasd/supported").await?) |
There was a problem hiding this comment.
Perhaps it might be good to have a /storage/supported or /storage/features that returns which features are actually supported in a single place. But I guess it is out of scope here.
There was a problem hiding this comment.
makes sense for me, but I would do it in separate PR as it affects also web UI
| pub async fn set_config(&self, config: &ZFCPConfig) -> Result<(), ZFCPHTTPClientError> { | ||
| if !self.supported().await? { | ||
| // TODO: should we add tracing error here? | ||
| return Ok(()); |
There was a problem hiding this comment.
By now I would most probably add a warning.
There was a problem hiding this comment.
question is if we should add tracing to agama-lib as currently it is only in agama-server and agama-network
Co-authored-by: Imobach González Sosa <[email protected]>
jreidinger
force-pushed
the
zfcp_unattended
branch
from
1991184 to
ddca271
Compare
imobachgs
changed the title
imobachgs
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is missing support to activate zFCP devices in unattended agama.
Solution
Implement it and also together with it fix also wrong dasd export at https://bugzilla.suse.com/show_bug.cgi?id=1246102
Testing
Manually tested with following profile ( first select product and then test it using
agama config load. We cannot test it with full unatttended profile as our only s390 machine with zfcp available is already installed, so we tested it on installed system ){ "zfcp": { "devices": [ { "channel": "0.0.fa00", "wwpn": "0x500507630b181216", "lun": "0x4020404900000000" } ] } }Documentation
related PR agama-project/agama-project.github.io#96