Update usb-device to v0.3 #17
Open
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersimple33
suggested changes
Jun 8, 2024
examples/arduino_keyboard.rs
Outdated
| use avr_device::{asm::sleep, interrupt}; | ||
| use usb_device::{ | ||
| class_prelude::UsbBusAllocator, | ||
| descriptor::lang_id::LangID::EN, |
There was a problem hiding this comment.
This should be just descriptor::lang_id::LangID else rust complains of LangID not being a module
examples/arduino_keyboard.rs
Outdated
|
|
||
| let hid_class = HIDClass::new(usb_bus, KeyboardReport::desc(), 1); | ||
| let usb_device = UsbDeviceBuilder::new(usb_bus, UsbVidPid(0x1209, 0x0001)) | ||
| let strings = StringDescriptors::new(EN) |
There was a problem hiding this comment.
Consequently this should be let strings = StringDescriptors::new(LangID::EN)
supersimple33
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.3 version of usb-device comes with some incompatible changes, so a minor amount of migration is required. An update of usbd-hid is required for the same reason.