-
Notifications
You must be signed in to change notification settings - Fork 46
Add Haskell.Data.List
#396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
omelkonian
merged 5 commits into
agda:master
from
HeinrichApfelmus:HeinrichApfelmus/data-list
Mar 10, 2025
Merged
Add Haskell.Data.List
#396
omelkonian
merged 5 commits into
agda:master
from
HeinrichApfelmus:HeinrichApfelmus/data-list
Mar 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespercockx
approved these changes
Jan 27, 2025
Member
jespercockx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have a few minor nitpicks, but otherwise this looks very good.
bbe636e to
2cf0f3d
Compare
omelkonian
requested changes
Mar 10, 2025
2cf0f3d to
3365fa5
Compare
omelkonian
reviewed
Mar 10, 2025
3365fa5 to
15f452e
Compare
omelkonian
reviewed
Mar 10, 2025
15f452e to
4cea90b
Compare
omelkonian
approved these changes
Mar 10, 2025
Contributor
omelkonian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to add some functions from the module
Data.List. Specifically, we addnubwith a proof of a propertyprop-elem-nubdeleteAllas a helper function fornubsortas a postulateWe also add
Haskell.Data.Ord, this is needed forsortOn.I quite like the property
as it expresses a logical equivalence in terms of
≡, I think that this is only available forBool, not forProp/Set. The proof is also very succinct.On the other hand, the proof for
prop-elem-deleteAllis somewhat lengthy, but I'm not sure that this can be avoided, as we have to use transitivity of==at crucial points in the proof. I am using the induction hypothesisprop-elem-deleteAll x y zsin awithclause in order to avoid doing substitutions by hand viacong.