Rename Set to Type
#397
Merged
Rename Set to Type
#397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/set-to-type
branch
2 times, most recently
from
6d0667d to
fecee0b
Compare
omelkonian
approved these changes
Mar 7, 2025
Contributor
omelkonian
left a comment
omelkonian
left a comment
There was a problem hiding this comment.
LGTM, just a couple of minor omissions.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/set-to-type
branch
from
fecee0b to
625c3e7
Compare
Contributor
Author
|
Thanks for your review! I have just noticed that the documentation still mentioned @omelkonian could you take another look? If you're happy, could you also merge the pull request? — I do not have sufficient permissions to merge anything, this pull request is coming from a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the name
Typeinstead of the nameSetfor all types that are transpiled to Haskell. This change has two motivations:Type.Setfrom thecontainerspackage.Using
Typeinstead ofSetremoves a small, yet pervasive stumbling block for people who know Haskell and want to learn Agda2hs. In principle, people can learn the difference, but in this case, I believe that this is learning effort not well-spent.(In a future change, it may make sense to introduce
Propin addition toTypein order to better distinguish between propositions about Haskell and types in Haskell — while every Haskell type can be transpiled from aType, the converse is not true. But that discussion is out of scope for this pull request.)