-
Notifications
You must be signed in to change notification settings - Fork 46
Add containers-lib to nix flake packages
#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containers-lib to nix flake packages
#407
Conversation
|
@jespercockx Thanks! Could you merge the pull request? — I don't have any permissions on this repository. 😅 |
|
Actually, I think that there is something wrong when Nix typechecks the Somehow, transitive dependencies do not compose just yet ( |
|
do you mean these lines? https://github.com/agda/agda2hs/actions/runs/14793443918/job/41535343556#step:5:204 (and till 304 or so) |
Yes and no.
Yes. However, the problem is that We need an equivalent https://github.com/HeinrichApfelmus/bags/blob/main/nix/lib.nix but haven't managed to backport it yet. |
|
Hmm, I'm not sure I understand exactly. What do you consider to be a "built derivation" for agda2hs? If it's agda+agdai files and agda2hs then doesn't behave the same way agda proper does, I think I see the problem. I'd be surprised if agda2hs behaved very differently here, but it can be. |
Yep, that's indeed the case and the problem.
Consequently, when compiling a downstream file with |
|
Ah, indeed. |
b7066bc to
cdb5392
Compare
|
@liesnikov I have added a custom definition of This works, in downstream code, I can now do agda2hs-custom = agda2hs.lib.${system}.withPackages ([
agda2hs.packages.${system}.base-lib
agda2hs.packages.${system}.containers-lib
]);and get a variant of |
cdb5392 to
a1727bc
Compare
|
@liesnikov @HeinrichApfelmus what's the current status of this PR? What's needed for it to get into a mergeable state? |
The changes are complete as far as I am concerned. The CI had failed for spurious reasons, I'll try to restart it. |
|
CI passes. @jespercockx do you want me to merge? |
This pull request adds an attribute
containers-libto thepackagesoutput inflake.nix. In this way, users can provision thecontainers-libusing Nix.This is an addendum to #406 to make
containers.agda-libuseable with Nix.Note: This pull request also changes the version of the
base-libattribute to match the version4.18of thebasepackage on Hackage.