Add module hierarchy Agda2Hs.Language.Haskell
#413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/language-haskell
branch
from
07c18a5 to
0a91a73
Compare
jespercockx
approved these changes
May 27, 2025
Member
jespercockx
left a comment
jespercockx
left a comment
There was a problem hiding this comment.
This looks fine to me. I'm not too excited about all the extra noise of the Hs. prefixes. However it does make things more consistent, so perhaps it's fine.
omelkonian
requested changes
May 28, 2025
Contributor
omelkonian
left a comment
omelkonian
left a comment
There was a problem hiding this comment.
I'm happy with the file organization and more compact imports, but please revert most changes in the terms where you introduced Hs..
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/language-haskell
branch
from
0a91a73 to
a60b7be
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a module hierarchy at
Agda2Hs.Language.Haskellthat represents the Haskell language syntax from the viewpoint ofAgda2Hs.This module hierarchy essentially re-exports a subset
haskell-src-exts, but also assimilates the oldAgda2Hs.HsUtilsmodule.Comments
Agda2Hs.Language.Haskellin which the problem and its solution are supposed to reside.ghc-source-gen#274 is implemented, then it would go throughAgda2Hs.Language.Haskellas well. That said,Agda2Hs.Language.Haskellre-exports the opinion ofhaskell-src-extson how Haskell code looks like — if didn't re-export the opinion, then it would present an alternate opinion, essentially duplicatinghaskell-src-exts. The idea is thatAgda2Hs.Language.Haskellis a re-export ofhaskell-src-exts, but with a couple of utilities that are specific to Agda2Hs added.