-
Notifications
You must be signed in to change notification settings - Fork 17
User defined right hand side function #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agdestein
wants to merge
40
commits into
main
Choose a base branch
from
generic-f
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 59.08% 62.79% +3.70%
==========================================
Files 26 22 -4
Lines 3556 2857 -699
==========================================
- Hits 2101 1794 -307
+ Misses 1455 1063 -392 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is more transparent, since we cannot "prescribe" the Reynolds number as it changes during the simulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some breaking changes.
Now the user can choose the force (add body force, closure terms etc.).
By default, it is just decaying turbulence (convection + diffusion).
Breaking changes
Setupnow expects a viscosityviscinstead of Reynolds numberRe.Do
Setup(; ..., visc = 1e-3)instead ofSetup(; ..., Re = 1e3).This is more transparent, as the Reynolds number cannot be prescribed when
uis changing during the simulation, but the viscosity is constant.solve_unsteady, it defaults tonavierstokes!without temperature equation, andboussinesq!with temperature equation. This can be overridden by doingsolve_unsteady(; force! = custom_force!, ...).solve_unsteadyshould now besolve_unsteady(; start, ...)instead ofsolve_unsteady(; ustart, tempstart, ...), wherestartis eitherstart = (; u)orstart = (; u, temp). Theforce!acts on a statestate = (; u)orstate = (; u, temp), and writes the forces to a second state containing the forces foruandtemprespectively.force!function to the solver, and not hard-coded in theSetupfunction. See the examples folder for examples.Other changes
A new fast spectral-like Poisson solver
psolver_transformis available, that uses DCT in addition to FFT. This allows for periodic directions and walls.