Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually added activities to be true by default #24

Merged

Conversation

nicastelo
Copy link
Contributor

I think manually added activities should be included by default.

If you check the old repo, there are a lot of open issues saying several methods are not working, when really the issue was they wanted to retrieve manually added data and they were not specifying that in the call.

I know the old module wasn't too much clear about it, and that's was probably part of the problem. But the fact that many people opened issues says to me that the module should retrieve manually added data by default.

Here are some of those issues
lucaspbordignon/rn-apple-healthkit#140
lucaspbordignon/rn-apple-healthkit#164
lucaspbordignon/rn-apple-healthkit#155
lucaspbordignon/rn-apple-healthkit#151

@lucaspbordignon lucaspbordignon self-assigned this Nov 23, 2020
@lucaspbordignon lucaspbordignon added the enhancement New feature or request label Nov 23, 2020
@lucaspbordignon
Copy link
Contributor

Hey @nicastelo!

Thanks for the contribution on that. This behaviour is something that makes people confused when using the library for the first time and I agree with you that we should have that as true by default

We should also be very clear in the documentation about this breaking change for new versions of the library and where we have this flag available, but I can probably handle that for the new release. Also, feel free to give any suggestion on that process

@lucaspbordignon lucaspbordignon merged commit 7542630 into agencyenterprise:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants