Skip to content

Conversation

@hcars
Copy link

@hcars hcars commented Mar 31, 2020

Fixed the problem for the newer versions of django with the six import.

Copy link

@grchang2020 grchang2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this fix, since six is not supported by newer versions of django and without this fix the code doesn't run.
Do you also need to update the django-graphos/demo_project/requirements.txt file to include six?

Copy link

@woodmicha woodmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for sure! Thanks for doing it.

@eriktelepovsky
Copy link

+1

Added `six` to requirements.txt
@hcars
Copy link
Author

hcars commented Jun 22, 2021

I agree with this fix, since six is not supported by newer versions of django and without this fix the code doesn't run.
Do you also need to update the django-graphos/demo_project/requirements.txt file to include six?

I just added it to the requirements.txt file.

@utking
Copy link

utking commented Sep 12, 2021

Are there plans to merge this PR in the fairly near future? It allows the library to be working with the current Django versions, finally.

@hcars
Copy link
Author

hcars commented Sep 13, 2021

Are there plans to merge this PR in the fairly near future? It allows the library to be working with the current Django versions, finally.

@grchang2020 please approve the changes when you can.

@eriktelepovsky
Copy link

I presume this library is dead...

@woodmicha
Copy link

woodmicha commented Jan 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants