Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of compiler warnings #239

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Fix a number of compiler warnings #239

merged 4 commits into from
Jun 6, 2024

Conversation

glaubitz
Copy link
Contributor

@glaubitz glaubitz commented Jun 5, 2024

  • Fix incorrect format specifiers when calling sprintf()
  • Fix potentially uninitialized variable
  • Remove unused variables

@coveralls
Copy link

Coverage Status

coverage: 93.542%. remained the same
when pulling ab40a39 on glaubitz:warning-fixes
into 8794b37 on agronholm:master.

@glaubitz glaubitz mentioned this pull request Jun 5, 2024
Merged
@coveralls
Copy link

Coverage Status

coverage: 93.542%. remained the same
when pulling b1c8bd2 on glaubitz:warning-fixes
into a4ebd57 on agronholm:master.

@coveralls
Copy link

Coverage Status

coverage: 93.542%. remained the same
when pulling db83674 on glaubitz:warning-fixes
into 573d520 on agronholm:master.

@agronholm agronholm merged commit 13681d5 into agronholm:master Jun 6, 2024
15 checks passed
@agronholm
Copy link
Owner

Thanks!

@glaubitz
Copy link
Contributor Author

glaubitz commented Jun 6, 2024

Great, thanks. Hoping for a release soon so distributions currently switching to GCC 14 can drop the local patches.

@agronholm
Copy link
Owner

v5.6.4 is brewing right now: https://github.com/agronholm/cbor2/actions/runs/9397794316

@glaubitz
Copy link
Contributor Author

glaubitz commented Jun 6, 2024

v5.6.4 is brewing right now: https://github.com/agronholm/cbor2/actions/runs/9397794316

Awesome, thanks. I'll update it in openSUSE as soon it's out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agronholm agronholm agronholm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glaubitz @coveralls @agronholm