Skip to content

Fixed MySQL DOUBLE column type rendering #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2025
Merged

Fixed MySQL DOUBLE column type rendering #371

merged 5 commits into from
Feb 28, 2025

Conversation

agronholm
Copy link
Owner

Fixes #335.

@coveralls
Copy link

coveralls commented Feb 24, 2025 •
edited
Loading

Coverage Status

coverage: 97.055% (-0.002%) from 97.057%
when pulling 8516825 on fix-mysql-double
into 6da9a0b on master.

sheinbergon
sheinbergon requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@sheinbergon sheinbergon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a better way

@sheinbergon sheinbergon self-requested a review February 28, 2025 00:18
@sheinbergon sheinbergon removed their request for review February 28, 2025 13:39
@sheinbergon sheinbergon merged commit 99b73c0 into master Feb 28, 2025
7 of 8 checks passed
@sheinbergon sheinbergon deleted the fix-mysql-double branch February 28, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheinbergon sheinbergon sheinbergon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL DOUBLE(11,2) is converted to Double(11, True)
3 participants
@agronholm @coveralls @sheinbergon