forked from noeltimothy/chronos
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported chronos project from Python 2.7 to Python 3 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python2.7 should not be installed in the Dockerfile. The Docker build fails on my Mac M1 and on a EC2 instance. Please provide the docker build command you used, the output, and a list of the architectures you tested the build on.
|
@ i am not able to solve it sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
Summary
This PR updates the chronos project to Python 3 for improved compatibility and modernization. It also updates the Dockerfile and entrypoint.sh script to remove dependencies on Python 2.7 and ensure smooth operation with Python 3.
Changes Made
Codebase Conversion:
Used 2to3 tool to automatically convert Python 2.7 code to Python 3.
Manually verified and tested code changes to ensure functionality.
Dockerfile Update:
Replaced Python 2.7 with Python 3 in the Dockerfile.
Updated system and Python package dependencies to support Python 3.
Entrypoint Script Update:
Modified entrypoint.sh script to use Python 3 commands and syntax.
Testing and Validation:
Built and tested the Docker image to ensure the application runs without errors using Python 3.
Verified functionality through the web interface and connected devices.