Skip to content

Conversation

sozercan
Copy link

@sozercan sozercan commented Oct 14, 2025

Overview:

multiple --exclude arguments doesn't work, and it ends up over the requested pvc size for gpt-oss 120b

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation

    • Clarified HuggingFace CLI instructions for downloading models, showing how to pass multiple exclusion patterns correctly. Improves copy-paste reliability and reduces download errors.
  • Chores

    • Standardized the model download recipe by consolidating exclusion patterns into a single command invocation, ensuring consistent behavior across environments and smoother downloads.

Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan requested review from a team as code owners October 14, 2025 17:10
Copy link

copy-pr-bot bot commented Oct 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

👋 Hi sozercan! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added fix external-contribution Pull request is from an external contributor labels Oct 14, 2025
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Updated Hugging Face CLI download exclusion arguments in one doc and one recipe: adjusted handling of "metal/*" by removing a separate --exclude in docs and consolidating exclusion patterns in the YAML recipe. No functional, logic, or control-flow changes.

Changes

Cohort / File(s) Summary of changes
HF download exclusion args
docs/backends/trtllm/gpt-oss.md, recipes/gpt-oss-120b/model-cache/model-download.yaml
Harmonized Hugging Face CLI exclusions: doc removes a second --exclude and passes "metal/*" as a standalone arg; recipe consolidates patterns into a single --exclude with multiple values. No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my ears at flags that roam,
Two paths to skip, now tidied home.
One hop, one exclude—so clean, so light,
The cache will purr through download night.
Thump-thump, I sign: exclusions tight! 🐇✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description follows the template structure but has empty Details and Where should the reviewer start sections and uses a placeholder issue number instead of a real reference, leaving critical information incomplete. The Overview briefly states the problem but does not describe the actual changes made. Related Issues lists a placeholder rather than linking to a concrete GitHub issue. Please complete the Details section with a summary of the modifications made, specify the files or sections the reviewer should inspect under Where should the reviewer start, and replace the placeholder issue number with the actual issue reference.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately describes the change to the Hugging Face CLI exclusion flags by indicating a fix to HF CLI exclusions and is concise and clear. The prefix “fix:” follows conventional commit style and highlights the nature of the change. Therefore, it fully captures the main change from the developer’s perspective.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa1d651 and 4212c27.

📒 Files selected for processing (2)
  • docs/backends/trtllm/gpt-oss.md (1 hunks)
  • recipes/gpt-oss-120b/model-cache/model-download.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@athreesh
Copy link
Contributor

@grahamking looks like a small fix. can you take a look and approve if it looks good?

@athreesh athreesh requested a review from grahamking October 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants