-
Notifications
You must be signed in to change notification settings - Fork 641
fix: hf cli exclusions #3610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: hf cli exclusions #3610
Conversation
Signed-off-by: Sertac Ozercan <[email protected]>
👋 Hi sozercan! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughUpdated Hugging Face CLI download exclusion arguments in one doc and one recipe: adjusted handling of "metal/*" by removing a separate --exclude in docs and consolidating exclusion patterns in the YAML recipe. No functional, logic, or control-flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@grahamking looks like a small fix. can you take a look and approve if it looks good? |
Overview:
multiple
--exclude
arguments doesn't work, and it ends up over the requested pvc size for gpt-oss 120bDetails:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Documentation
Chores