-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: million cli #572
feat: million cli #572
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'd suggest to use https://github.com/natemoo-re/clack in the CLI by @natemoo-re |
@rishi-raj-jain this looks nice. |
I'm afraid not |
See https://github.com/getsentry/sentry-wizard/blob/master/src/nextjs/nextjs-wizard.ts which is a pretty solid example for using clack on a sdk setup wizard. |
Thanks @AbhiPrasad . this would really help alot it in the process. |
Hello @aidenybai . can you test the PR in your local. Things which are complete by now-
Things left -
One more thing wouldn't it conflict with million currently present in npm registry because of same name? |
@kunal00000 any updates on this? |
@aidenybai do million support reejs as of now? Also PR is ready for merge. Added documentation too. |
@renhiyama afaik there are no users using both million and packit together. we can add packit once there is a feature request for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to run pnpm lint and pnpm cleanup at root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to run pnpm lint and pnpm cleanup at root
Please describe the changes this PR makes and why it should be merged:
This PR will be adding a CLI for million js setup.
Features
will resolve #571
/claim #571
Status
Semantic versioning classification: