Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Snake Game #738

Merged
merged 3 commits into from
Oct 25, 2023
Merged

added Snake Game #738

merged 3 commits into from
Oct 25, 2023

Conversation

sr2005roy
Copy link
Contributor

@sr2005roy sr2005roy commented Oct 13, 2023 •
edited by tobySolutions
Loading

Please describe the changes this PR makes and why it should be merged:

Kitchen Sink: Added A Snake Game
resolves #638
closed: Kitchen Sink: Build A Snake Game
images:
image
image

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 10:50am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 10:50am

@sr2005roy
Copy link
Contributor Author

@tobySolutions can you please check the PR under hactoberfest-accepted label

@tobySolutions
Copy link
Contributor

@tobySolutions can you please check the PR under hactoberfest-accepted label

Reviewing this now. Thanks @sr2005roy.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6511684456

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%
Totals Coverage Status
Change from base Build 6493361542: 0.0%
Covered Lines: 1257
Relevant Lines: 5082
💛 - Coveralls

tobySolutions
tobySolutions approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, your changes LGTM!!

Could you maybe check out the responsiveness on mobile maybe?

Screenshot 2023-10-14 at 19 40 29

packages/kitchen-sink/src/examples/snakeGame.jsx Outdated Show resolved Hide resolved
packages/kitchen-sink/src/examples/snakeGame.jsx Outdated Show resolved Hide resolved
packages/kitchen-sink/src/style.css Outdated Show resolved Hide resolved
@tobySolutions
Copy link
Contributor

Any updates on this @sr2005roy?

@sr2005roy sr2005roy closed this Oct 20, 2023
@sr2005roy sr2005roy reopened this Oct 20, 2023
@sr2005roy
Copy link
Contributor Author

I have made all the changes

@sr2005roy
Copy link
Contributor Author

Now kindly check @tobySolutions

@sr2005roy sr2005roy mentioned this pull request Oct 20, 2023
Closed
1 task
@akshayw1
Copy link

@sr2005roy Need a help in order to make PR in kitchen sink? Could you pls explain in steps

@tobySolutions
Copy link
Contributor

Now kindly check @tobySolutions

Awesome! I'm gonna check this out now.

tobySolutions
tobySolutions approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome!

@tobySolutions tobySolutions merged commit 4fe3002 into aidenybai:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobySolutions tobySolutions tobySolutions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Snake Game
4 participants
@sr2005roy @tobySolutions @coveralls @akshayw1