Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BmiCalculator.jsx file for kitchen sink #768

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Added BmiCalculator.jsx file for kitchen sink #768

merged 4 commits into from
Oct 30, 2023

Conversation

rakshixh
Copy link
Contributor

@rakshixh rakshixh commented Oct 21, 2023

User have to input their age, gender, height in feet and inch also weight. Based on that BMI is given along with category such as underweight, overweight, normal, etc.

Fixes #752

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:36am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:36am

@coveralls
Copy link

coveralls commented Oct 21, 2023

Pull Request Test Coverage Report for Build 6650389047

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6646258217: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions
Copy link
Contributor

Can you please review the responsiveness on mobile @rakshixh?

@rakshixh
Copy link
Contributor Author

Sure @tobySolutions will update you once the responsiveness is reviewed!

@rakshixh
Copy link
Contributor Author

Hey, @tobySolutions made changes to the BMI calculator file for responsiveness. Also deleted the count-down timer file so that for this issue only the bmi file can be there in the commit as you requested.

@tobySolutions
Copy link
Contributor

Thanks @rakshixh, reviewing now.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work @rakshixh.

@tobySolutions tobySolutions merged commit d03a23f into aidenybai:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: BMI Calculator
3 participants