Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #766- Done making temperature converter app #774

Closed
wants to merge 1 commit into from
Closed

Fix #766- Done making temperature converter app #774

wants to merge 1 commit into from

Conversation

shubhalgupta
Copy link

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 9:48am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 9:48am

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shubhalgupta
Copy link
Author

@tobySolutions please kindly review this!

@shubhalgupta
Copy link
Author

@tobySolutions why is it closed, shouldn't it get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhalgupta @CLAassistant @tobySolutions