Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plurality of "users" in status #788

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

quackduck
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Simple fix: when there is only a single user online on a page, use "user" instead of "users" so we don't end up with "1 users connected"

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:44pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:44pm

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

@quackduck
Copy link
Contributor Author

wait did this not get merged

@aidenybai aidenybai reopened this Nov 1, 2023
@aidenybai aidenybai merged commit 9652d92 into aidenybai:main Nov 1, 2023
3 checks passed
@aidenybai
Copy link
Owner

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants