fix: SDK irregularities and commits / branch addition #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
commit: |
- Removed unused imports and variables - Reorganized code for better readability - Added optional parameters for path, params, commit, and branch in Monitoring component - Updated getSession function to accept optional commit and branch parameters - Updated flush function to pass commit and branch to getSession - Updated toPayloadInteraction function to include commit and branch in interaction payload - Updated initPerformanceMonitoring function to include commit and branch in performance entry - Updated Session interface to include url, route, commit, and branch properties - Updated Interaction interface to include commit and branch properties - Updated InternalInteraction interface to include commit and branch properties - Updated AstroMonitor component to use path instead of pathname prop - Updated AstroMonitor component to pass path and params to computeRoute function - Updated MonitoringWithoutRouteProps interface to include optional commit and branch properties
NisargIO
force-pushed
the
nisarg/commits-and-paths
branch
from
49e5698 to
725addc
Compare
- Updated the `getInteractionId` function to clarify path replacement behavior. - Refactored `splitInteractions` to use a for-loop instead of forEach for better performance. - Changed the initialization of `pendingInteractions` and `completedInteractions` to use `new Array<InternalInteraction>()`. - Enhanced type definitions by adding `Component` to imports from './types'. - Improved code readability and organization.
- Added a warning message to the build scripts in both root and scan package to remind developers to bump the version before building. - Refactored file handling in `tsup.config.ts` to use `fs/promises` for asynchronous file operations. - Enhanced the `flush` function in the network monitoring module to improve interaction handling and ensure proper session management. - Updated type definitions for `Interaction` and `Component` to allow for numeric interaction IDs. - Modified the `getSession` function to include the package version in the session data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.