refactor: props, states and contexts view #166
Conversation
|
@pivanov is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
| const contextObj: Record<string, unknown> = {}; | ||
|
|
||
| contexts.forEach((value, contextName) => { | ||
| contextObj[contextName] = value.displayValue; |
There was a problem hiding this comment.
Take note: in the future we might want to change this implementation, as this is a megamorphic code (hurts perf)
| whatChangedSection: createHTMLTemplate<HTMLDetailsElement>( | ||
| `<details class="react-scan-what-changed" style="background-color:#b8860b;color:#ffff00;padding:5px"> | ||
| <summary class="font-bold">What changed?</summary> | ||
| </details>`, |
There was a problem hiding this comment.
quotes and closing tags are optional, but this is fine. Although new lines and tabs/spaces, definitely we want to shave off.
|
|
||
| const currentContext = getCurrentContext(fiber); | ||
| if (Object.keys(currentContext).length) { | ||
| tryOrElse(() => { |
There was a problem hiding this comment.
in the future, it should be of preference that we should use try-catch directly instead of using utilities like this (for 2 reasons: JS compilers cannot optimize this + closures are painful to optimize with). The utility itself has some ideal uses, but not in this case, I guess. Don't worry, I'll fix this one.
props-states-context.mov