🔧 Pin abipy version
#316
Merged
🔧 Pin abipy version
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the close dependency of `abipy` on `pymatgen`, and our own dependencies on `pymatgen`, it is challenging to install both packages in one environment. Version `0.9.6` of `abipy` was released after some specific changes were made to ensure it can install with our current `master` branch, which we intend to release for the oxide verification paper. Since it is highly likely that the next version of `abipy` will make changes to the code to update it for `pymatgen` versions we no longer support, we pin the version to this release.
Trying to install the package for Python 3.10 fails due to an issue with PyYAML==5.4.1, see: yaml/pyyaml#724 As we are currently working on a release for `aiida-core` v1.6.X, which does not support Python 3.10, we remove support for Python 3.10 here as well.
|
@sphuber let's merge these separately from the wien2k PR and the rebase. I'd add you as a reviewer but not sure how to do that on my phone. 😅 PS: they should be rebased and merged. More commits means higher code registry ranking. 😉 |
sphuber
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the close dependency of
abipyonpymatgen, and our own dependencies onpymatgen, it is challenging to install both packages in one environment.Version
0.9.6ofabipywas released after some specific changes were made to ensure it can install with our currentmasterbranch, which we intend to release for the oxide verification paper. Since it is highly likely that the next version ofabipywill make changes to the code to update it forpymatgenversions we no longer support, we pin the version to this release.