Adding support for custom protocols #347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, only implemented for QE and abinit, needs to be implemented for all Also, fixing a couple of bugs in the ACWF relax for ABINIT
Contributor
|
Thanks, Giovanni! I'm not sure when I renamed the forces output in the plugin (it's even marked for backwards-compatibility), but great that you caught it. I'll give this a deeper look on Monday. |
Contributor
|
After a second look, this looks reasonable to me and shouldn't be too hard to add for all the codes 👍🏼 |
This allows to override the protocol ones by the launching user by using a custom protocol
giovannipizzi
force-pushed
the
add_custom_protocols
branch
from
c912898 to
0ecc634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very often one wants a custom protocol, but it's not convenient to add a protocol definition in this repo for every independent project. Therefore, I'm here supporting the possibility to pass the protocol as a dictionary.
Note: For now, only implemented for QE and abinit, needs to be implemented for all if we agree on how I did it.
Note: In this PR I also fixing a couple of bugs in the ACWF relax for ABINIT.