Skip to content

Add dedicated path type throughout the codebase #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ayushjariyal
Copy link
Contributor

issue #6814

In this PR, I introduce a unified PathType alias in aiida/common/types.py to replace inconsistent path-like annotations.
This improves consistency and readability.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (660fec7) to head (0a6e54b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6819      +/-   ##
==========================================
- Coverage   78.31%   78.30%   -0.01%     
==========================================
  Files         566      567       +1     
  Lines       42762    42771       +9     
==========================================
+ Hits        33484    33486       +2     
- Misses       9278     9285       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas changed the title Adding Dedicated path througout the codebase Add dedicated path type throughout the codebase Apr 22, 2025
Copy link
Contributor

@khsrali khsrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushjariyal
Overall looks good!
Please also unify TransportPath with this new path.

@ayushjariyal ayushjariyal requested a review from khsrali April 23, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants