Skip to content

Fix legacy pytest fixtures #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented May 20, 2025

Fixes #6881

Error in the failing tests:

Error: Invalid value for '-p' / '--profile': profile c01e3952-46ee-4a12-9fe8-a960a5593e19 does not exist

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (43176cb) to head (e5adde7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/manage/tests/test_pytest_fixtures.py 98.25% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6882      +/-   ##
==========================================
+ Coverage   78.60%   79.20%   +0.60%     
==========================================
  Files         567      568       +1     
  Lines       43097    43183      +86     
==========================================
+ Hits        33871    34197     +326     
+ Misses       9226     8986     -240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas
Copy link
Collaborator Author

@agoscinski just heads up that I think this should be included in the 2.7.0 release otherwise we risk breaking people's CIs (as it broke aiidalab-widgets-base). I can work on this over the weekend to drive it home.

@danielhollas danielhollas force-pushed the fix-legacy-fixtures branch from 6db7e2d to c34f72e Compare May 26, 2025 23:06
@danielhollas danielhollas changed the title WIP: Fix legacy pytest fixtures Fix legacy pytest fixtures May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy pytest fixtures broken on 2.7.0rc0
1 participant