Skip to content

Send Slack notification if test-install.yml fails #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented May 26, 2025

This PR adds the Slack notification step to the test-install.yml workflow that runs automatically on the main branch, but until now any failures were not reported, so we for example missed the problem with the new click version (#6885).

  • To prevent duplication I've created a new slack-notification action, and use it in both nightly.yml and test-install.yml workflows.

  • Lastly, I decided to skip the notifications on runs triggered from pull requests (regardless whether they come from fork or origin) since in that case the failure is obvious in the GitHub UI so no need to send message to Slack.

This PR from is intentionally from the origin repo so that I could test that the notifications actually work, and indeed they are, see messages in the #aiida-core-dev Slack channel from May 26. To see that the notifications are properly skipped, see #6896.

@danielhollas danielhollas marked this pull request as ready for review May 26, 2025 01:26
@danielhollas danielhollas requested review from agoscinski and unkcpz May 26, 2025 01:26
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (e1d55fa) to head (d14fa55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6897   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files         567      567           
  Lines       43096    43096           
=======================================
  Hits        33868    33868           
  Misses       9228     9228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agoscinski
Copy link
Contributor

Thanks for the PR. Seems to me not relevant for release so I put it aside to v2.7.1 since the slack devops is a bit complicated and I dont have any experience with

@danielhollas
Copy link
Collaborator Author

@agoscinski no worries. Just btw that I basically just copy pasted the snippet from the nightly workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants