Skip to content

Support numpy 2.x #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented May 27, 2025

Looks like numpy 2.x just....works?

(we should still probably wait before merging this until after release 2.7 just to be on the safe side, and we can then release in 2.7.1?)

See #6898

Warning from docs build, no idea where it comes from since we don't reference numpy.bool anywhere. I've added numpy.bool to nitpicks-exceptions

/home/docs/checkouts/readthedocs.org/user_builds/aiida-core/checkouts/6899/src/aiida/orm/nodes/data/base.py:docstring of aiida.orm.nodes.data.base.to_aiida_type:1: WARNING: py:class reference target not found: numpy.bool

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (e1d55fa) to head (46b4c88).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6899      +/-   ##
==========================================
+ Coverage   78.59%   78.59%   +0.01%     
==========================================
  Files         567      567              
  Lines       43096    43096              
==========================================
+ Hits        33868    33869       +1     
+ Misses       9228     9227       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas changed the title WIP: Testing numpy 2.x Support numpy 2.x May 27, 2025
@danielhollas danielhollas marked this pull request as ready for review May 27, 2025 22:48
Copy link
Collaborator Author

@danielhollas danielhollas May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like updating numpy in the lockfile had a cascading effect, here's the relevant diff

@@ -43,7 +44,8 @@ dependencies = [
     { name = "kiwipy", extra = ["rmq"] },
-    { name = "numpy" },
+    { name = "numpy", version = "2.0.2", source = { registry = "https://pypi.org/simple" }, marker = "python_full_version < '3.10'" },
+    { name = "numpy", version = "2.2.6", source = { registry = "https://pypi.org/simple" }, marker = "python_full_version >= '3.10'" },
     { name = "paramiko" },
     { name = "pgsu" },

I just ran uv lock --upgrade-package numpy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant