Skip to content

Transport: unify the behavior of core.ssh_async::glob with core.ssh::glob #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Jul 17, 2025

Fixes #6949

This PR suggest two changes in core.ssh_async interface:

  • catch and raise a better error message if the connection fails to open
  • globing of a non-existing path or an unmatched pattern will not raise anymore, instead it will just returns an empty list. This is to respect the same convention of core.ssh behavior

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.18%. Comparing base (b235b3a) to head (df42da7).

Files with missing lines Patch % Lines
src/aiida/transports/plugins/ssh_async.py 71.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6950      +/-   ##
==========================================
- Coverage   79.20%   79.18%   -0.01%     
==========================================
  Files         566      566              
  Lines       43461    43470       +9     
==========================================
- Hits        34417    34416       -1     
- Misses       9044     9054      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbercx
Copy link
Member

mbercx commented Jul 17, 2025

Thanks @khsrali! I'll give a spin and do a proper review on Monday, have some scientific tasks to take care of today. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👌 Improve usage of core.ssh_async transport
2 participants