Skip to content

Conversation

GeigerJ2
Copy link
Contributor

@GeigerJ2 GeigerJ2 commented Oct 6, 2025

This is to (hopefully) avoid flaky performance benchmark regressions like here by fixing the seed for the large JSON tests.

I'm not sure if it can be fully avoided with GHA runners, as their performance is inherently non-deterministic, but at least one can try 😅

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.27%. Comparing base (cf690e4) to head (8f1c5ae).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7047       +/-   ##
===========================================
+ Coverage   27.16%   79.27%   +52.11%     
===========================================
  Files         566      566               
  Lines       43807    43807               
===========================================
+ Hits        11896    34722    +22826     
+ Misses      31911     9085    -22826     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GeigerJ2 GeigerJ2 requested a review from rabbull October 14, 2025 10:19
@GeigerJ2 GeigerJ2 force-pushed the devex/seed-json-benchmarks branch from dc831fe to aab5c68 Compare October 14, 2025 10:19
@rabbull
Copy link
Contributor

rabbull commented Oct 14, 2025

LGTM. Though probably fixed seeds would not entirely resolve the issue, it should at least alleviate it.

BTW I think it worth link to this existing issue: #6730

Update:
I noticed that a test is failing, but I can't see the relationship between the case and this PR. Is it also failing as well on main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants