[Docs] add Graph task for While logic#587
Merged
superstar54 merged 3 commits intoaiidateam:mainfrom Jul 20, 2025
Merged
Conversation
6971e27 to
119b4d8
Compare
119b4d8 to
3f53974
Compare
edan-bainglass
approved these changes
Jul 20, 2025
Member
edan-bainglass
left a comment
There was a problem hiding this comment.
In general, LGTM! I am a bit concerned regarding the impact on the graph visualization. Also, what is the plan to remove the pickling workaround?
Member
Author
I don't know how to replace the workaround for the moment, 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interesting thing is that the current
Graphtask supports the while logic out of the box. Surprise, but nice. 🚀Here I update the doc, and a small change in the
graphtask api.control-flow, addGraphtask for theWhilelogicgraphtask to return a value too.Graphtask execution, use a temporary workaround to fix the pickle error for the recursive call.doc preview: https://aiida-workgraph--587.org.readthedocs.build/en/587/howto/autogen/control-flow.html#id7