Add an update method #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update method can save two membership checks over a delete followed by an insert, because we don't need to bother calculating / verifying the intermediate root
KtorZ
reviewed
Jun 6, 2024
| old_value: ByteArray, | ||
| new_value: ByteArray, | ||
| ) { | ||
| // TODO: could we do this with a single traversal? `something(key, old_value, new_value, proof) -> (old_root, new_root)`? |
There was a problem hiding this comment.
I've done -- at some point -- something similar for including / excluding since only the last step in the traversal really is different. But in the end, there's an extra cost that comes from having more arguments to keep track of and you still need the same number of hashes and prefix manipulation so there's almost no visible benefits on the execution costs in doing so. And, it obfuscates the code a lot more, so I gave up on the idea eventually.
KtorZ
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update method can save two membership checks over a delete followed by an insert, because we don't need to bother calculating / verifying the intermediate root
It doesn't include off-chain code for doing updates because I got intimidated, and it's not as useful to safe computation there lol